feat(parser): Handle a few more use cases of potential count attributes. #260
+129
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cheton Not sure why the Ci is not starting. |
|
It looks like the workflow is awaiting approval from a maintainer for the test to run 😢 |
cheton
approved these changes
Jun 3, 2024
|
It looks like everything is green. Could you merge the PR @cheton ? |
|
@vincentdesmares Sorry for the delay. This change has been released in version 4.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our original problem is that: due to an upgrade of i18next version and a move to typescript, many of our plural uses-cases using the Trans component do not work anymore.
This pull request answers a few translations that are not taken in account with the current parser.
Checklist
npm run testChecklist (for documentation change)